[FW][FIX] pivot: preserve pivot UI after undo

fw-bot commented 1 month ago

Steps to reproduce (in odoo):

insert a pivot in a spreadsheet
snapshot the spreadsheet by leaving it and opening it again
remove the pivot definition
undo => crash boom

This is a partial revert of 22625e8730ccc

It was actually intended to keep the pivot runtime definition when deleting the pivot core definition. The goal was to avoid redoing RPC to reload the pivot after an UNDO.

2 alternatives considered:

add "REMOVE_PIVOT" to UNDO_REDO_PIVOT_COMMANDS to properly recreate the pivot. But spreadsheet pivot would be recreated twice :/ (and it'd be more RPCs
remove the cleaning and check if the pivot core definition exists.

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

[ ] feature is organized in plugin, or UI components
[ ] support of duplicate sheet (deep copy)
[ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
[ ] in model/UI: ranges are strings (to show the user)
[ ] undo-able commands (uses this.history.update)
[ ] multiuser-able commands (has inverse commands and transformations where needed)
[ ] new/updated/removed commands are documented
[ ] exportable in excel
[ ] translations (_t("qmsdf %s", abc))
[ ] unit tested
[ ] clean commented code
[ ] track breaking changes
[ ] doc is rebuild (npm run doc)
[ ] status is correct in Odoo

Forward-Port-Of: odoo/o-spreadsheet#4863

robodoo commented 1 month ago

fw-bot commented 1 month ago

@LucasLefevre @pro-odoo this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

pro-odoo commented 1 month ago

robodoo r+

On Wed, Aug 21, 2024 at 11:39 AM robodoo @.***> wrote:

[image: Pull request status dashboard] https://mergebot.odoo.com/odoo/o-spreadsheet/pull/4874

— Reply to this email directly, view it on GitHub https://github.com/odoo/o-spreadsheet/pull/4874#issuecomment-2301612209, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFIBHV6R7NVBH2QTDMSABDZSRN5BAVCNFSM6AAAAABM3UDBFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRGYYTEMRQHE . You are receiving this because you were mentioned.Message ID: @.***>

odoo / o-spreadsheet

[FW][FIX] pivot: preserve pivot UI after undo #4874

Description:

review checklist