odoo / o-spreadsheet

Other
193 stars 44 forks source link

[FW][FIX] pivot: sorting of undefined headers #4898

Closed fw-bot closed 1 month ago

fw-bot commented 1 month ago

Steps to reproduce:

=> The headers are sorted in the following order: "Alice", "(Undefined)", "Olaf".

The root cause was that the sorting function sorts the keys of the groupby, and the key of the undefined object is the string "null" and so it was sorted between the A of Alice and the O of Olaf.

Task: 4123261

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

Forward-Port-Of: odoo/o-spreadsheet#4864

robodoo commented 1 month ago

Pull request status dashboard

fw-bot commented 1 month ago

@pro-odoo @rrahir this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

fw-bot commented 1 month ago

@pro-odoo @rrahir ci/runbot failed on this forward-port PR

rrahir commented 1 month ago

@robodoo r+

robodoo commented 1 month ago

@rrahir you may want to rebuild or fix this PR as it has failed CI.

rrahir commented 1 month ago

@robodoo r+

fw-bot commented 1 month ago

@pro-odoo @rrahir this PR was modified / updated and has become a normal PR. It must be merged directly.