odoo / o-spreadsheet

Other
193 stars 44 forks source link

[FW][FIX] clipboard: Fix paste as value for in localized sheet #4899

Closed fw-bot closed 1 month ago

fw-bot commented 1 month ago

When pasting as value, we would re-localize the payload before writing it on the cell. However, The content of a cell is supposed to be "canonical" so the conversion to the localized value was probably a mistake.

Task: 4104432

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

Forward-Port-Of: odoo/o-spreadsheet#4790

robodoo commented 1 month ago

Pull request status dashboard

fw-bot commented 1 month ago

@rrahir @LucasLefevre cherrypicking of pull request odoo/o-spreadsheet#4790 failed.

stdout:

Auto-merging src/helpers/clipboard/clipboard_cells_state.ts
CONFLICT (content): Merge conflict in src/helpers/clipboard/clipboard_cells_state.ts
Auto-merging tests/clipboard/clipboard_plugin.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

:warning: after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

fw-bot commented 1 month ago

@rrahir @LucasLefevre this forward port of odoo/o-spreadsheet#4790 is awaiting action (not merged or closed).

rrahir commented 1 month ago

@robodoo r+