odoo / o-spreadsheet

Other
195 stars 44 forks source link

[FW][FIX] composer: overflow on composer at end of screen #5255

Closed fw-bot closed 4 days ago

fw-bot commented 4 days ago

Description

The button to close the composer's formula assistant would overflow for the viewport and make an additional scrollbar appear when it's at the end of the screen (eg. standalone composer in the CF color scale panel).

This was due to two things: 1) there was a comment with //, which is invalid css and disabled the width property of the button 2) we were using a CLOSE_ICON_RADIUS to compute the position of the formula assistant. But this constant wasn't actually used in the CSS, so the button could have an arbitrary width unrelated to the constant. (in practice it was 18.4px vs 18px, but this would change if we changed the font size).

Task: 4315958

review checklist

Forward-Port-Of: odoo/o-spreadsheet#5252

robodoo commented 4 days ago

Pull request status dashboard

fw-bot commented 4 days ago

@hokolomopo @rrahir this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

hokolomopo commented 4 days ago

@robodoo r+