odoo / o-spreadsheet

Other
195 stars 44 forks source link

[FW][IMP] conditional_format: improve CF data bar behavior for non-matching range sizes #5266

Open fw-bot opened 2 days ago

fw-bot commented 2 days ago

Before this commit, defining a CF data bar rule based on the value of another range requires both ranges to have matching sizes, preventing the CF from being created otherwise. This restriction leads to a poor user experience when copying and pasting CFs, as the CF does not get pasted.

This commit removes the restriction, allowing CF creation in a "best effort" manner when the range sizes do not match. The CF style is therefore applied by comparing the matching cells.

Task: 4280720

review checklist

Forward-Port-Of: odoo/o-spreadsheet#5164

robodoo commented 2 days ago

Pull request status dashboard

fw-bot commented 2 days ago

@rachico @LucasLefevre cherrypicking of pull request odoo/o-spreadsheet#5164 failed.

stdout:

Auto-merging src/components/translations_terms.ts
Auto-merging src/plugins/core/conditional_format.ts
CONFLICT (content): Merge conflict in src/plugins/core/conditional_format.ts
Auto-merging src/plugins/ui_core_views/evaluation_conditional_format.ts
Auto-merging src/types/commands.ts
Auto-merging tests/conditional_formatting/conditional_formatting_plugin.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

:warning: after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port