search

odoo / odoo-extra

unsupported addons (runbot, document_fs)
117 stars 245 forks source link

[IMP] runbot: add kill button #119

Closed Icallhimtest closed 7 years ago

Icallhimtest commented 7 years ago

Allow logged users to kill builds that are pending or testing.

The kill button solves the following problem:

When you have a community and enterprise branch with pull request. The enterprise PR gets fetched before the branch by runbot, so it builds with the community master branch instead of the corresponding community branch. As the branch shares the same HEAD as the PR, so no other build is done for the branch.

Previously you had to wait the build to finish building, then rebuild it from the branch, taking twice the time necessary. Now you'll be able to kill & rebuild it just after pushing the branch.

Also having a kill button is globally a nice to have feature.

Icallhimtest commented 7 years ago

Woo !

KangOl commented 7 years ago

Still, there was a few errors: https://github.com/odoo/odoo-extra/compare/37ee888bbf6378cce62ae74bcf5ab8674cdff8e5...8799edeab1f5a6bf678e1702739630b782e9f89c

Icallhimtest commented 7 years ago

indeed...

Thanks