[12] Mixed content on customer invoices

[cgarnier]

Impacted versions: 12 (docker) Steps to reproduce: Send an invoice by mail, click on the button in the mail. Current behavior: The invoice page dont load correcly. The preview doesnt display and there is a mixed content error in the preview. Expected behavior: Load with no error and wither the preview.

Video/Screenshot link (optional):

http is redirected to https by the loadbalancer (traefik) web.base.url starts with https web.base.url.freeze is True

[pedrobaeza]

This is something on your deployment, as I don't get that problem in mine. Check your proxy configuration, werkzeug version and so on.

Closing meanwhile there's no more proof of Odoo itself issue.

[cgarnier]

Please dont close it until i didnt find where is the issue.

[pedrobaeza]

I will open it when that happens.

[cgarnier]

I found that the src link of the iframe: https://xxxx/my/invoices/6?access_token=448fa9da-1338-42cd-9df8-b6f71f081f8b&report_type=html

is making a 302 redirection to http://xxxx/FR_fr/my/invoices/6?access_token=448fa9da-1338-42cd-9df8-b6f71f081f8b&report_type=html

It s what is causing the mixed content. I dont understand yet why odoo is redirecting with a http link.

[pedrobaeza]

As said, that's because your proxy or werkzeug version. I can't deep more, as it depends on that configurations that are very different per configuration, but you can check that with our Docker solution - https://github.com/Tecnativa/doodba - it's working, as fast option for contrasting the problem (this is not advertising, but a way to check that is working).

[cgarnier]

In fact i just added proxy_mode = True in /etc/odoo/odoo.conf and now it s working well.

[pedrobaeza]

Oh, I was assuming you already had that. Well, I noted for others with the same problem. Glad you found the deployment problem.

[cgarnier]

Maybe you could add a paragraph about it in this readme: https://hub.docker.com/_/odoo I think most people use this docker behind a reverse proxy. Thanks for your help.

[pedrobaeza]

Well, I'm only a contributor giving a hand managing Odoo issues, but not Odoo employee or Docker image maintainer, but I think it's your duty to check general documentation about that, where it's indicated: https://www.odoo.com/documentation/12.0/setup/deploy.html

[cgarnier]

Yes you right, but the point to use docker is to not have to read install documentation :D It should work out the box by linking services together and it should expose some usefull env var to setup this kind of options.

[pedrobaeza]

I don't agree on that part. Docker only provides a layer for not bothering with some install things. But this is configuration, not installation, and you can't assume that default configuration. For example, enabling that and using Docker for development in local machine with that option would make it to fail in other ways.

[cgarnier]

Yes ofcource but this kind of options should be settable via some env var to not have to edit any conf files. -e ODOO_PROXY_MODE=True

[pedrobaeza]

Well, for that, you should:

• Check that there's no already an option for that.
• Check if there has been already requests about this and the answer.
• Put the issue for suggesting that or the PR adding the option in that project, not here.

[alexandregodard]

Hi, In my config Proxy_mode=True, web.base.url = https://... and web.base.url.freeze =True weren't enough

Need to fixe my nginx proxy too with : _proxy_setheader X-Forwarded-Host $host; proxy_set_header X-Forwarded-Proto $scheme; proxy_set_header X-Real-IP $remote_addr;