search

odoogap / vuestorefront

30 stars 25 forks source link

[FIX] graphql_vuestorefront: get_product_price #10

Closed oerp-odoo closed 1 year ago

oerp-odoo commented 1 year ago

There is no such method get_product_price in product.pricelist ( it was changed to _get_product_price ~2 years ago).

Also, we must check if product_id exists, because it will break _get_product_price call, which expects product to be non empty!

bfigueiredo-odoogap commented 1 year ago

Hi @oerp-odoo, thanks for the help.

We inspected into this and you are right. The function get_product_price was updated on the v16.0 to _get_product_price. But also on the input variables, we should only pass the product and the add_qty.

The code are now updated, i will close the PR. Thanks. :)

oerp-odoo commented 1 year ago

@bfigueiredo-odoogap thanks!

oerp-odoo commented 1 year ago

Though may I ask, why you are not merging pull requests, but committing separately?:)

bfigueiredo-odoogap commented 1 year ago

Yes i could just merge and update what you did and fix it. Sorry for that, on the next time i will take that in consideration. :) One more time, thanks for the help!