[8.0 sale_order_taxes] sale order amount_tax field should be computed like taxes

odoomrp / odoomrp-wip

WIP of OdooMRP

http://www.odoomrp.com

GNU Affero General Public License v3.0

117 stars 247 forks source link

[8.0 sale_order_taxes] sale order amount_tax field should be computed like taxes #1333

Open cvinh opened 8 years ago

cvinh commented 8 years ago

Steps to reproduce :

Install sale_order_taxes (v8.0)
setup currency without decimals
setup a 5% tax and a 13% tax
make a quotation with qty=915 price_unit=150 taxes = 5%,13%
compute totals
we have 5% tax amount = 6863 (base =137250)
we have 13% tax amount = 17843 (base = 137250)

Bad behaviour :

amount_untaxed = 24705
amount_total =161955 Good behaviour :
amount_untaxed = 24706
amount_total = 161956

cvinh commented 8 years ago

I did a PR here

cvinh commented 8 years ago

@pedrobaeza By the way, I think tax_calculation_rounding_method parameter should be taken into account in sales orders... what do you think ?

pedrobaeza commented 8 years ago

@oihane, any opinion on this?

cvinh commented 7 years ago

@pedrobaeza I think that issue is related to https://github.com/OCA/OCB/pull/576 If that PR is merged in odoo, It could be backport in v8... ?

pedrobaeza commented 7 years ago

I'm not sure that it's related, because taxes computation in v8 is different. Anyway, I'm not maintaining anymore this module. Let's see if @oihane can say anything.