search

odota / core

Open source Dota 2 data platform
https://www.opendota.com
MIT License
1.51k stars 303 forks source link

Extra information needed in /proMatches endpoint #1594

Open AnujDutt2701 opened 6 years ago

AnujDutt2701 commented 6 years ago

1). Please add radiant_team_logo, dire_team_logo and league_logo information. 2). If possible, could you add game number alongside series_type as well? like game 1 in a bo3 series. It could be done on the client side but there are cases when all games in the series may not be returned in a single query.

howardchung commented 6 years ago

team logos should be possible with sql query.

league logo needs another step to fetch the image url from valve

I don't think game number is available in the API, you'll have to infer it based on match ID.

AnujDutt2701 commented 6 years ago

league logo needs another step to fetch the image url from valve

Is it not implementable then?

I don't think game number is available in the API, you'll have to infer it based on match ID.

I could compare records against match_id for the same series_id. But on the client side, there would be certain edge cases where for example I would have only 2 games with me for a bo3 series coz the oldest game might be outside the limit of 100 records fetched. In this case my calculation will return game 2 of 3, whereas it would actually be game 3. I'm not sure if I'm clearly expressing my issue across.

howardchung commented 6 years ago

league logo is implementable, it just requires another change to fetch the logo URL (it's not already in the database).

You may want to drop incomplete series (if not all the matches in a series are in the result set).