Rework cosmetics service

odota / core

Open source Dota 2 data platform

https://www.opendota.com

MIT License

1.51k stars 303 forks source link

Closed builder-247 closed 11 months ago

builder-247 commented 11 months ago

Changed items_game.txt source from SteamDB to d2vpkr, since it's no longer tracked there
Retrieve CDN URLs from my tool https://github.com/builder-247/node-dota2-cdn, I intend to automate this further
Rewrite the service to use promises instead of callbacks

howardchung commented 11 months ago

Awesome, thanks for fixing this! It's been great working with modernized code so far--debating trying to go to TypeScript at some point haha

builder-247 commented 11 months ago

Awesome, thanks for fixing this! It's been great working with modernized code so far--debating trying to go to TypeScript at some point haha

It sure was an interesting issue, didn't expect to spend my day in a hex editor when I started on this. Learned a lot nonetheless.