upsert - Githubissues

odota / core

Open source Dota 2 data platform

https://www.opendota.com

MIT License

1.5k stars 300 forks source link

upsert #787

Closed howardchung closed 8 years ago

howardchung commented 8 years ago

This will be released in January.

[x] We'll need to do a pg_upgrade or dump/restore
[x] We can also stop using the messy insert, err, update flow with native upsert and can add transactions to make match and player_match insertion atomic.
[ ] change postgres version in travis

howardchung commented 8 years ago

Kubernetes should take care of upgrade (and the dump/restore the data upgrade) but we'll need to edit queries.js to support upserts.

howardchung commented 8 years ago

So I implemented my own custom "genValue" function that builds an upsert query for postgres (see queries.js), but it feels hacky. I would like knex.js to have support for it, but they don't seem to be moving quickly. If we really want this we can use my homebrewed solution but we should test it carefully before deploying to production.