search

odota / dotaconstants

Constant data for Dota applications
MIT License
298 stars 120 forks source link

Missing 7.16.0 #138

Closed kuwood closed 1 year ago

kuwood commented 1 year ago

I have noticed the core project's package.json references 7.16.0. But it looks after the 7.33 additions this package was never bumped? The open dota api currently does not have any of the items from patch 7.33.

howardchung commented 1 year ago

On npm the 7.16.0 package is published, that commit may not have been published to github.

https://www.npmjs.com/package/dotaconstants

But if 7.16.0 does not contain the new items then we need to push 7.17.0

kuwood commented 1 year ago

Interesting, we are using the explorer api with the sql SELECT id as valve_id, localized_name as name, name as dota_name FROM items; and for instance item with the id 4204 is not in the response. But i can see it here https://github.com/odota/dotaconstants/blob/master/build/items.json#L1202 :confused:

howardchung commented 1 year ago

The SQL items table I think is using an outdated Valve API that no longer updates.

kuwood commented 1 year ago

oh wow, ok thank you for clearing that up. Ill look for another approach :+1: