Open mcetkovsky opened 6 years ago
Sure, we can add tooltips/subtitles for those. Are there any more terms that are confusing?
There is lots of them where I have a feeling of missing something.
Few more examples:
In general, I would welcome if all stats, graphs and numbers has at least the following (if it makes sense):
Thanks for the list! We'll probably gradually add tooltips/subtitles in for these areas. Feel free to submit a PR if you want to join the effort.
For the histograms we can probably add it to the subtitle part of the Heading component: https://www.opendota.com/players/88367253/histograms/comeback
For others we can use tooltips (see existing tooltips for reference code)
We could also implement tooltips for more abbreviations like here for example: https://www.opendota.com/records
Sure we could also rely on people reading the target URL which explains that HH stands for Hero Healing but it could be confusing for mobile users.
With a more general Tooltip
and TooltipContainer
component we could also implement more informations without using much space.
I encountered a problem with match details interpretation (all examples from match 3861782528 ). I'll be glad if you explain it to me and add some notes for them:
Hi How can i contribute to this issue?
You could go through the list provided by https://github.com/odota/web/issues/1342#issuecomment-347510522 and determine if adding tooltips/additional text to the page would be helpful.
I am working on the tooltips for the fantasy page of matches. There doesn't seem to be a string for tooltips relating to roshan kills. Is it acceptable to use string.farm_roshan? Or should a new string be added, and if that is the preferred solution what is the best way to add a string for cross language support?
That string is fine.
If adding a new string, you add it only to en-US.json, the rest will be automatically generated.
Hi, can I still work on this issue?
Yes, you can! Do you have a particular section you want to start with?
i would like to contribute to this issue , how can i start with
Thanks, @howardchung. I've checked the list in #1342 comment. Seems like the Rankings tab still doesn't have any description yet. I'd love to add some tooltips for the numbers. To be honest, I'm also confused about the meaning of those numbers. Probably will dig into the code to see they are calculated.
The score is basically increased on a win and decreased on a loss, with higher gains and smaller losses awarded when playing against opponents of higher rank.
Can I help to this in anyway?
Yes, but you'll need to identify an area that's confusing first. This may not be a good first issue, so I'll remove the tag.
There are lot of pages, acronyms and stats which has no explanation what the stat/metric tracks, how it is calculated (if it is not clear from its title) and whether lower/higher is better (if makes sense) so it is understandable for new comers or casual gamers.
For example, I don't find self-explainable the Comeback, KLA and Map pings.
Note for "lower/higher is better", I would not include this info for Map pings because maxing it does not make sense (lower but smart pings is better than lots of meaningless pings which is something not easily to measure objectively).