search

odota / web

React web interface for the OpenDota platform
https://www.opendota.com
MIT License
1.09k stars 391 forks source link

Purchase log not accurate #2268

Open worthy7 opened 4 years ago

worthy7 commented 4 years ago

Current Behavior Purchase log shows entire items bought instead of their recipe.

Expected behavior/code Actually bought items to be show

Possible Solution I think the purchase log page should shoe exactly what was purchased (not the item, but the recipe if it is an upgrade). If this cannot be done, then instead, it should be like it is inside the dota 2 client, showing snapshots of the heros inventory at each time period.

Additional context/Screenshots Add any other context about the problem here. If applicable, add screenshots to help explain. image In this example it appears that between the 0 and 5 minute mark this sniper "purchased": 3 Wrath bans, 2 headbans and 1 agility boots. What most likely actually happened was: Bought 2 headbands and 1 agility boots, which filled in the items needed to BECOME 3 wrath bands.

I propose that instead of "purchase log" we have "inventory" instead, and show the inventory of the characters at the 0, 5, 10 etc minute marks. This is much more accurate and informative, and is what dota itself does.

howardchung commented 4 years ago

Snapshotting the inventory every 5 minutes seems reasonable, but I think we also don't want to give up the log as it gives the exact timestamp.

The appearance of multiple items that combine is a known issue, but it's the raw data we get from the log so I'm not sure if we can do anything about it.

worthy7 commented 4 years ago

So the raw data doesn't distinguish between the "item" and the "Recipe:Item" ? Is this stream the only data you can pull about items bought/owned?

howardchung commented 4 years ago

You can get the items in inventory at any point in time, but that will also show as 3 wraith bands showing up. I believe recipe purchases have already been filtered out of this display to avoid clutter.

worthy7 commented 4 years ago

3 Wraith bands are fine - if it's just that. There would be no other items in the inventory at that point. But of course that means 1 call for every 5 mins of every game... right

On Tue, 5 Nov 2019 at 17:44, Howard Chung notifications@github.com wrote:

You can get the items in inventory at any point in time, but that will also show as 3 wraith bands showing up. I believe recipe purchases have already been filtered out of this display to avoid clutter.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/odota/web/issues/2268?email_source=notifications&email_token=ABEKWH3X6I6RX2ZVVCGCDHDQSEW7XA5CNFSM4JI4OHEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDCBMEA#issuecomment-549721616, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEKWHZIBLNU27G6XWQQDGTQSEW7XANCNFSM4JI4OHEA .