search

odota / web

React web interface for the OpenDota platform
https://www.opendota.com
MIT License
1.09k stars 394 forks source link

Cosmetics tab doesn't show some items #2781

Closed Armin-GS closed 10 months ago

Armin-GS commented 3 years ago

Current Behavior Some cosmetics don't appear in the cosmetics tab

Expected behavior/code All equipped cosmetics should be listed

Possible Solution I don't know how this website works but this problem seems to be occurring for relatively new cosmetics. Probably the list of cosmetics defined here is not up to date and it can't find the definition of some cosmetics and show them?

Additional context/Screenshots I've checked some items from diretide chest and none of them are listed (neither Immortals nor set pieces), so the problem might be only with this chest.

howardchung commented 3 years ago

hmm yeah maybe the data source we use is no longer updated?

can you list some examples?

Armin-GS commented 3 years ago

can you list some examples?

I've checked my account and some other accounts' games knowing what cosmetics they have and all I have noticed is the whole diretide chest items are missing. I am not sure if there are other chests with the same problem since I don't own any cosmetics from those chests. the new dota+ chest will most likely be absent as well since it's relatively new like the diretide cosmetics.

morganrmcconnon commented 3 years ago

I've also noticed that TI9 and TI10 Immortals aren't showing up in the matches/cosmetics section of the schema.

https://www.opendota.com/matches/5976728036/cosmetics (Rectifier from TI9) Rectifier from TI9

https://www.opendota.com/matches/5971748672/cosmetics (Stuntwood Symbiont from TI10) Stuntwood Symbiont from TI10

morganrmcconnon commented 3 years ago

hmm yeah maybe the data source we use is no longer updated?

As far as I can tell, the cosmetic data source is the SteamDatabase link listed in core/svc/cosmetics.js, which is currently up to date.

Armin-GS commented 3 years ago

hmm yeah maybe the data source we use is no longer updated?

As far as I can tell, the cosmetic data source is the SteamDatabase link listed in core/svc/cosmetics.js, which is currently up to date.

I checked this list and all items missing from the website are present here. TI immortals commented above, and diretide cosmetics, and most likely all items are listed here.

howardchung commented 10 months ago

Recent cosmetics fixes hopefully should have also fixed this