search

odota / web

React web interface for the OpenDota platform
https://www.opendota.com
MIT License
1.09k stars 391 forks source link

Show if a player's matches are being hidden #3133

Closed howardchung closed 6 months ago

howardchung commented 9 months ago

Now that we're not displaying data for players with public match data disabled, we should update the UI to show a message if this is the case.

We can check the fh_unavailable property on the player call, and display a message like: "This player has disabled public match history. If this is you, sign in to view your own data."

jeyren95 commented 7 months ago

hi can i take this too?

howardchung commented 7 months ago

Yes

jeyren95 commented 7 months ago

Are you looking to move towards typescript + hooks?

If yes, i could also do the conversion for the relevant files i will be updating in this issue.

Idt there are many files to change anw, so the conversion will not be too major

howardchung commented 7 months ago

Ideally the TS conversion could go in one PR and then feature change in another

howardchung commented 7 months ago

Note: We recently re-enabled showing data for pro players. So we also want to check if the player is a pro player and not show the "hidden" message if so

jeyren95 commented 7 months ago

Have opened a PR, do help to take a quick look whenever you're free, thanks!

jeyren95 commented 7 months ago

created a PR https://github.com/odota/web/pull/3156, pls help to take a look whenever you're free, thanks!