odota / web

React web interface for the OpenDota platform
https://www.opendota.com
MIT License
1.08k stars 390 forks source link

404 images on hero page, https://www.opendota.com/heroes/86 #3137

Closed Geczy closed 6 months ago

Geczy commented 6 months ago

Current Behavior

https://www.opendota.com/heroes/86

404 image

image

Expected behavior/code

show image

howardchung commented 6 months ago

Looks like in dotaconstants we just need to filter out:

  "rubick_hidden1",
  "rubick_hidden2",
  "rubick_hidden3",
Geczy commented 6 months ago

Rubicks not the only hero. It's a bunch of them so I think we need a different fix. Check batrider too

howardchung commented 6 months ago

I think we just have to manually exclude all of these, unless we can identify a pattern

Geczy commented 6 months ago

Looking into it, we can fix this by filtering on "behavior": "Hidden",

https://github.com/odota/web/pull/3138