search

odota / web

React web interface for the OpenDota platform
https://www.opendota.com
MIT License
1.07k stars 390 forks source link

feat(issue-3133): hide player matches if player profile is private #3151

Closed jeyren95 closed 4 months ago

jeyren95 commented 4 months ago
  1. Added retrieving of list of pro player IDs
  2. Player profile should be private if player account id is not within the list of pro player IDs, and the player's "fh_unavailable" property is true
  3. Disabled tabs if player profile is private
  4. Added CTA to direct players to login if their profile is private, but they wish to see their stats

Screenshot 2024-02-11 151555

^ yatoro is a pro player but this is just for reference on how the page should look like

howardchung commented 4 months ago

I think we missed a case here--for players who are signed in and trying to view their own profile.

howardchung commented 4 months ago

Also, we have to allow access to the refresh button to update the availability status--so we should either only hide the w/l row, or not hide anything at all

howardchung commented 4 months ago

I will revert this for now and we can re-merge when fixed

jeyren95 commented 4 months ago

ok noted on this, my bad for missing out on the scenario, will be fixing it asap. Anyway, I think it is alright to not hide anything at all ---> saw some dotabuff private profile examples, and they also do not hide the W/L stat