odota / web

React web interface for the OpenDota platform
https://www.opendota.com
MIT License
1.07k stars 390 forks source link

Add 7.34 draft order #3153

Closed ZacheryJohnson closed 4 months ago

ZacheryJohnson commented 4 months ago

Patch 7.34 changed the draft order and a corresponding mapping was not added to OpenDota. This PR adds support for this new draft order.


Tested by using the Battle Cup match 7580513318, which was played on 2024-02-10.

The draft should look as follows (the Dota client has some issues when jumping ahead in draft in replays it seems; the last pick for Dire was a Dragon Knight) draft

Prior to this change, the draft of a parsed game on OpenDota incorrectly showed the following: before

After this change, the draft appears correct in a parsed game: after

The Team Liquid v Azure Ray game, played today, also now displays correctly: tl-xg

Happy to test any additional matches as desired.


Note: the timestamp correlates to Tuesday, August 8, 2023 22:46:00 GMT, which I correlated to build ID 11896549 in Dota's SteamDB entry. I'm not sure if there's a more formal way to get an exact timestamp on when this new draft order should take effect, but I'm happy to do more digging if we'd prefer a more precise time.

734-steamdb

howardchung commented 4 months ago

I think we have a patch field in the match data (which is controlled by dotaconstants). That would save us having to define timestmaps here, but I think this is fine (we also have something similar for showing minimaps)