odow / SDDP.jl

A JuMP extension for Stochastic Dual Dynamic Programming
https://sddp.dev
Other
309 stars 61 forks source link

Running into some error (MSPFormat reader) #637

Closed bonnkleiford closed 1 year ago

bonnkleiford commented 1 year ago

Hi Oscar,

I was trying the MSPFormat reader function to try energy problem. Unfortunately, I ran into some error where one of the coefficients (price_6) of the objective function is not found. Here is the full error:

Screenshot 2023-07-06 at 21 25 55

Here are the two JSON files (problem and lattice) for reproduction purposes: Energy.zip

Best, BIKEY

odow commented 1 year ago

That's this line: https://github.com/odow/SDDP.jl/blob/e2e1ecb909f59fe51095250ca91a326d8565c543/src/MSPFormat.jl#L38

I think we discussed this, but I don't remember the conclusion. If a node i the lattice was missing a random variable, should we infer the value to be 0.0?

I'll re-iterate that I think this is a bad idea and a recipe for bugs. There's no need for file formats to be clever or save space. The zip file with and without the default values should be pretty similar.