odow / SDDP.jl

A JuMP extension for Stochastic Dual Dynamic Programming
https://sddp.dev
Other
309 stars 61 forks source link

Fix bug in MSPFormat reader #638

Closed odow closed 1 year ago

odow commented 1 year ago

Closes #637

I didn't test, but it seems like this is the likely culprit.

@bonnkleiford You can install this branch with:

] add SDDP#od/fix-msp-format
odow commented 1 year ago

Seemed to work so I'm going to merge:

julia> using SDDP
[ Info: Precompiling SDDP [f4570300-c277-11e8-125c-4912f86ce65d]

julia> m = SDDP.MSPFormat.read_from_file("/Users/Oscar/Downloads/Energy/Energy")

A policy graph with 22602 nodes.
 Node indices: 5461, ..., 5734
odow commented 1 year ago

Now you just need to install the latest version:

] add SDDP#master

If you confirm that this fixes the problem, I'll tag a new release.

bonnkleiford commented 1 year ago

HI Oscar,

I tried it and reading the problem (model and lattice JSON files) works but it cannot solve it. It still gives out the same error message: [image: Screenshot 2023-07-09 at 14.41.26.png]

Thanks again for the help.

On Fri, Jul 7, 2023 at 6:35 AM Oscar Dowson @.***> wrote:

Now you just need to install the latest version:

] add SDDP#master

If you confirm that this fixes the problem, I'll tag a new release.

— Reply to this email directly, view it on GitHub https://github.com/odow/SDDP.jl/pull/638#issuecomment-1624713436, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJAVHMXUKNVPADW3DKCV2G3XO6GYHANCNFSM6AAAAAA2BG54II . You are receiving this because you were mentioned.Message ID: <odow/SDDP. @.***>

-- With much respect,

Bonn Kleiford D. Seranilla, MOST PhD in Operations and Supply Chain Management Luxembourg Center for Logistics and Supply Chain Management University of Luxembourg @. @.> @.***

bonnkleiford commented 1 year ago

Also, I tried it with the rest of the synthetic problems and so far, I got a new error on one of them:

[image: Screenshot 2023-07-09 at 14.49.54.png]

In case you want to try:

On Sun, Jul 9, 2023 at 2:41 PM Bikey Bonn Kleiford Seranilla < @.***> wrote:

HI Oscar,

I tried it and reading the problem (model and lattice JSON files) works but it cannot solve it. It still gives out the same error message: [image: Screenshot 2023-07-09 at 14.41.26.png]

Thanks again for the help.

On Fri, Jul 7, 2023 at 6:35 AM Oscar Dowson @.***> wrote:

Now you just need to install the latest version:

] add SDDP#master

If you confirm that this fixes the problem, I'll tag a new release.

— Reply to this email directly, view it on GitHub https://github.com/odow/SDDP.jl/pull/638#issuecomment-1624713436, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJAVHMXUKNVPADW3DKCV2G3XO6GYHANCNFSM6AAAAAA2BG54II . You are receiving this because you were mentioned.Message ID: <odow/SDDP. @.***>

-- With much respect,

Bonn Kleiford D. Seranilla, MOST PhD in Operations and Supply Chain Management Luxembourg Center for Logistics and Supply Chain Management University of Luxembourg @. @.> @.***

-- With much respect,

Bonn Kleiford D. Seranilla, MOST PhD in Operations and Supply Chain Management Luxembourg Center for Logistics and Supply Chain Management University of Luxembourg @. @.> @.***

odow commented 1 year ago

Please provide reproducible examples. I can't see the screenshots

On Sun, 9 Jul 2023, 5:52 am Bikey Seranilla, @.***> wrote:

Also, I tried it with the rest of the synthetic problems and so far, I got a new error on one of them:

[image: Screenshot 2023-07-09 at 14.49.54.png]

In case you want to try:

On Sun, Jul 9, 2023 at 2:41 PM Bikey Bonn Kleiford Seranilla < @.***> wrote:

HI Oscar,

I tried it and reading the problem (model and lattice JSON files) works but it cannot solve it. It still gives out the same error message: [image: Screenshot 2023-07-09 at 14.41.26.png]

Thanks again for the help.

On Fri, Jul 7, 2023 at 6:35 AM Oscar Dowson @.***> wrote:

Now you just need to install the latest version:

] add SDDP#master

If you confirm that this fixes the problem, I'll tag a new release.

— Reply to this email directly, view it on GitHub https://github.com/odow/SDDP.jl/pull/638#issuecomment-1624713436, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AJAVHMXUKNVPADW3DKCV2G3XO6GYHANCNFSM6AAAAAA2BG54II>

. You are receiving this because you were mentioned.Message ID: <odow/SDDP. @.***>

-- With much respect,

Bonn Kleiford D. Seranilla, MOST PhD in Operations and Supply Chain Management Luxembourg Center for Logistics and Supply Chain Management University of Luxembourg @. @.> @.***

-- With much respect,

Bonn Kleiford D. Seranilla, MOST PhD in Operations and Supply Chain Management Luxembourg Center for Logistics and Supply Chain Management University of Luxembourg @. @.> @.***

— Reply to this email directly, view it on GitHub https://github.com/odow/SDDP.jl/pull/638#issuecomment-1627707367, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6MQJN5VKTK7GBXXSNGIUTXPKSPRANCNFSM6AAAAAA2BG54II . You are receiving this because you modified the open/close state.Message ID: @.***>

bonnkleiford commented 1 year ago

Hi Oscar,

For the Energy Problem, I still got the same error message:

Screenshot 2023-07-06 at 21 25 55

The issue was not on reading the problem (JSON files) but when SDDP.jl solves it, then I get the error message above.

For the other problem (Hydro_Simple), I got this error message when I read the JSON files:

Screenshot 2023-07-09 at 14 49 54

Here are the files for reproduction: Hydro_Simple.zip

Thanks!

odow commented 1 year ago

For the energy problem, I don't think you updated your version of SDDP.