odow / SDDP.jl

A JuMP extension for Stochastic Dual Dynamic Programming
https://sddp.dev
Other
304 stars 62 forks source link

Add warning to Statistical stopping rule #687

Closed odow closed 1 year ago

odow commented 1 year ago

A slight rant on why this is not a good stopping rule.

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (e2de34e) 92.73% compared to head (e00073a) 92.74%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #687 +/- ## ======================================= Coverage 92.73% 92.74% ======================================= Files 27 27 Lines 3346 3348 +2 ======================================= + Hits 3103 3105 +2 Misses 243 243 ``` | [Files](https://app.codecov.io/gh/odow/SDDP.jl/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oscar+Dowson) | Coverage Δ | | |---|---|---| | [src/plugins/stopping\_rules.jl](https://app.codecov.io/gh/odow/SDDP.jl/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oscar+Dowson#diff-c3JjL3BsdWdpbnMvc3RvcHBpbmdfcnVsZXMuamw=) | `94.16% <100.00%> (+0.09%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.