search

odow / SDDP.jl

A JuMP extension for Stochastic Dual Dynamic Programming
https://sddp.dev
Other
304 stars 62 forks source link

Fix non-constant state dimension in MSPFormat reader #695

Closed odow closed 11 months ago

odow commented 11 months ago

Closes #693

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (cb89e07) 92.74% compared to head (c674359) 92.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #695 +/- ## ========================================== + Coverage 92.74% 92.75% +0.01% ========================================== Files 27 27 Lines 3351 3356 +5 ========================================== + Hits 3108 3113 +5 Misses 243 243 ``` | [Files](https://app.codecov.io/gh/odow/SDDP.jl/pull/695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oscar+Dowson) | Coverage Δ | | |---|---|---| | [src/MSPFormat.jl](https://app.codecov.io/gh/odow/SDDP.jl/pull/695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oscar+Dowson#diff-c3JjL01TUEZvcm1hdC5qbA==) | `92.99% <100.00%> (+0.16%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

odow commented 11 months ago

This still can't read the files from https://github.com/bonnkleiford/MSPLib-Library/issues/2#issuecomment-1743130867 because there are other terms in the models that I don't know what to do with.

odow commented 11 months ago

cc @bonnkleiford