odpi / egeria-connector-xtdb

Pluggable repository for Egeria, using XTDB (formerly "Crux") as the back-end to natively support historical metadata.
https://odpi.github.io/egeria-docs/connectors/repository/xtdb/
Apache License 2.0
15 stars 7 forks source link

XTDB connector is not publishing the jar-with-dependencies #466

Open planetf1 opened 1 year ago

planetf1 commented 1 year ago

The gradle build is not building/packaging the -jar-with-dependencies

Noticed when trying to download via

http://oss.sonatype.org/service/local/artifact/maven/redirect\?r\=snapshots\&g\=org.odpi.egeria\&a\=egeria-connector-xtdb\&v\=4.0-SNAPSHOT\&c\=jar-with-dependencies

Found that the uber jar is built, but is not published in the maven package

The main egeria repo is uising the shadow plugin. Here we use a different approach but either should be fine. The plugin modifies the publish process, so when doing explicitly (as here) the publish step in gradle will also need updating

cmgrote commented 1 year ago

Ah, of course! I forgot that wasn't being published 🙈 If you're up to take a stab at it, even re-using the shadow-based approach, happy to receive it as a PR!

planetf1 commented 1 year ago

I noticed a few other improvements we could make, especially around consistency of dependencies, and reducing what we duplicate, but in the process hit https://github.com/odpi/egeria/issues/7421

Whilst building an uber jar doesn't require this, it's good to do a good job of validating a good connector build to prove out the artifacts we're creating in egeria are good. Looks like we have a regression in the BOM creation.

I may therefore put the bigger fix on hold, and just make the absolute minimal change to build a jar with dependencies! But I will then do the bigger update, just need to do a bit more experimenting/research on best practices around the BOM definitions. I may defer some of this but will aim to do it within the next week or two.

planetf1 commented 1 year ago

The main fix is done now, and merged.

However will leave open just to come back and refine the constraints & test