Closed planetf1 closed 2 years ago
Some questions also arise
The display name is set to 'boarding passes' but as with the Entity name, I think it should be 'seat_no'
Also if we have multiple postgres endpoints we are cataloguing (through multiple connections), will we not get an issue with the qualified name as it will no longer be unique - this is also a likely case?
If I follow the link (in REX) to the table, this is also called 'boarding_passes' (but in this case it's correct).
qualifiedName :postgres.bookings.BASE.boarding_passes
- what does BASE signify? And if this is a convention is there a reason we don't do similar for columns? (qualifiedName :postgres::bookings::boarding_passes::seat_no
<< is this in order to support both VIEWs and regular tables (BASE). That makes senseThere is some variance in naming of entities.
For example whilst tables (and in theory columns) use a simple name, DeployedDatabaseSchema uses a qualified name like postgres::postgres::bookings
as does RelationalDBSchemaType
Some of this may relate to the Data Manager OMAS vs the connector?
I notice the qualifiedName of the 'Database' Entity is simpl postgres - dup issue?
'Entity : postgres
Type : Database
Version : 1
Status : ACTIVE
Properties :
additionalProperties :
collate :en_US.UTF-8
ctype :en_US.UTF-8
encoding :6
name :postgres
version :PostgreSQL 11.12 on x86_64-pc-linux-gnu, compiled by gcc (Debian 8.3.0-6) 8.3.0, 64-bit
databaseVersion :PostgreSQL 11.12 on x86_64-pc-linux-gnu, compiled by gcc (Debian 8.3.0-6) 8.3.0, 64-bit
deployedImplementationType :postgres
name :postgres
qualifiedName :postgres
Column name is fixed by #84 Will re-review other mappings
@planetf1 There hasn't been a mapping yet, those are information schema name value pairs.
The SoftwareServer is created through the IT Infrastructure OMAS (when written). This is if IT Infrastructure cataloguing is required. In this case, the SoftwareServerCapability (DatabaseManager) is typically also created through IT Infrastructure OMAS and linked to the software server.
The Database Integrator OMIS will automatically create the DatabaseManager SoftwareServerCapability if not already created. It has minimal properties (just the qualifiedName) and no attempt is made to connect it to a SoftwareServer. The IT Infrastructure OMAS can then be used to fill out the SoftwareServerCapability (and link it to a SoftwareServer) at a later date if needed.
this is a question on the initial post
Egeria thinks that you have created a schema called bookings in the default postgres database. In that schema is a table called boarding_passes, with a column called seat_no
and it's this column that your actually looking at in REX , so we need to work out where it's going wrong, I assume your using the public schema ?
https://github.com/odpi/egeria-database-connectors/issues/79#issuecomment-863961126
This is a symptom of the lack of mapping, it's a postgres database , imported from a postgres database, which is called postgres. This will be cleared up when mapping is resolved.
https://github.com/odpi/egeria-database-connectors/issues/79#issuecomment-863949025 It was added to help debug an problem when querying for tables and views. It's actually the value that postgres uses to differentiate the two
I don't think there's anything wrong now -- the initial issue was with the names of columns being incorrect - but this is now fixed in the connector. The rest looked good in REX. Also agree with the point about software server.
The two outstanding points I see are a) The qualified names assigned for (for example) Database is a short name ie 'postgres'. This seems very short -- in most places the qualified names are longer. Just wanted to check whether that was intended and whether we have any challenges with uniqueness especially as more databases & database servers are imported. b) Whether you feel it useful to add any further docs clarifying the mappings. If we think what we have is sufficient for now, that's fine we can close this sub-issue.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.
I imported a 'flight booking' database from https://postgrespro.com/education/demodb (medium) This has a table called 'bookings'. If I inspect this with Egeria 'REX' I get:
Whilst some attributes are more obvious than others, anyone using this connector (and Egeria) really needs to understand not just what they mean from an Egeria perspective, but also the translation from postgres.
(As this is very technical a clear mapping/config file with annotations used by the code would be clear too)
Some of the questions/points that follow may be resolved by docs (many in fact), but there may be a few technical glitches too