If istio auto-sidecar-injection enabled in namespace, charts won't override

[planetf1]

If auto sidecar injection of istio is enabled at a namespace level, setting istio: enabled: false

isn't sufficient, since no annotations will be made to a pod definition to prevent this

Instead we need to actually pass the false value, not skip the annotation

ie

  annotations:
    {{ if .Values.istio.enabled }}
    sidecar.istio.io/inject: "true"
    {{- end }}

It's probably better to

• omit if that value is not defined at all (optional)
• set sidecar.istio.io/inject to false if it is disabled
• set to true if enabled

Istio does allow default configuration at the namespace level -- this annotation will just override in a pod specific way.

Mitigation - to stop using istio now, remove the annotation from the namespace.

[planetf1]

see https://istio.io/help/ops/setup/injection/

[planetf1]

To remove istio injection kubectl label namespace egeria istio-injection=disabled --overwrite

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

[planetf1]

still valid

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

[planetf1]

The VDC environment will need significant re-work to adapt to the many changes made in Egeria to better support metadata integration. Additionally the helm charts used for the lab & a simple base config have evolved to better support different types of services, exposing of ports, persistent storage etc.

As such specific incremental changes to the current - now old - charts do not really add value.

As such closing for now