search

odpi / egeria

Egeria core
https://egeria-project.org
Apache License 2.0
795 stars 259 forks source link

egeria-ui --server.servlet.context-path option #3181

Closed zoranid closed 3 years ago

zoranid commented 4 years ago

In case user wants to specify --server.servlet.context-path option, ui.yaml needs to be modified to modify container's entrypoint command. Probably better would be to propagate this into values.yaml as an option, so user would need just to specify an optional correct value in values.yaml. The change needs to be reflected in ingress.yaml as well.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

planetf1 commented 3 years ago

@sarbull This was originally brought up in relation to hosting the spring based UI. Given the refactoring that will occur in that UI shortly I think it's best you evaluate if any changes are needed in the k8s deployment after those changes are made specific to this issue

sarbull commented 3 years ago

@planetf1 we'll have to see at PR, i think some java spring ENV var will be removed (the required zuul ones), after this the backend it's all by itself with no link to the UI, the UI will be refactored so that it knows about the backend with the default deployment strategy we discussed by adding that ENV file which will provide minimal info for the THEME and API_URL and maybe other properties..

other than this, having the UI completely separated from the backend, anyone can decide what fits best for their needs as deployment

planetf1 commented 3 years ago

Given the refactoring it may be appropriate to close this issue now, and just ensure relevant docs are in place for deployment after the refactoring -

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.