odpi / egeria

Egeria core
https://egeria-project.org
Apache License 2.0
807 stars 261 forks source link

Analytics modeling client - no code, packaging warning #3606

Closed planetf1 closed 3 years ago

planetf1 commented 4 years ago

When publishing the 2.2 release in https://github.com/odpi/egeria/issues/3518 we get a warning:

2020-09-13T09:49:36.2977485Z RESULT - Sync analytics-modeling-client:2.2 = {"message":"In order to sync to Maven Central your package must be included in the JCenter repository"}

This is because the pom for this module says it is a jar, yet there is no code present.

Is the intent to add client code? If so let's leave as is. In general with a module if there isn't code it should be removed -- however this would be inconsistent with other OMASs

planetf1 commented 4 years ago

^ @yevgenmar

planetf1 commented 4 years ago

@yevgenmar is there a plan to add a client?

yevgenmar commented 4 years ago

Hi Nigel,

I did not have plan for client. As part of documentation I would like to have postman collection as example how to use the OMAS.

Sincerely Yevgeniy


From: Nigel Jones notifications@github.com Sent: September 18, 2020 6:14 AM To: odpi/egeria egeria@noreply.github.com Cc: yevgenmar yevgenmar@hotmail.com; Mention mention@noreply.github.com Subject: Re: [odpi/egeria] Analytics modeling client - no code, packaging warning (#3606)

@yevgenmarhttps://github.com/yevgenmar is there a plan to add a client?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/odpi/egeria/issues/3606#issuecomment-694783070, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABFPQCWURMPWSD4L2YYPKA3SGMXJBANCNFSM4RLHUBZQ.

planetf1 commented 4 years ago

The postman collection would be useful... I think if we have a general purpose interface we should really have a client, as this is consistent with our other OMASs.

Whilst in development it's inevitable the implementation is incomplete, but as we get it closer to released status I think then we should look at it

However if there is consensus we don't need/want a client then we can remove the stub build files to avoid the initial error above.

A long time ago we put together some guidelines for OMASs though having read them they are only rough notes, and as a community we need to improve! (fyi https://github.com/odpi/egeria/blob/master/developer-resources/standards-for-omas-implementations.md )

planetf1 commented 3 years ago

FYI error from publishing build 2.4:

Hi planetf1,

Thank you for submitting this request,

JCenter follows the maven convention. In addition to the .jar and .pom file, your version should include a sources jar, and optionally a javadoc jar.

Your files should be under a maven path layout.
(See https://www.jfrog.com/confluence/display/BT/Central+Repositories+New+UI#CentralRepositoriesNewUI-JCenter)
github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

planetf1 commented 3 years ago

If there is no need, and no intent, to provide a client, I suggest that module is removed.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

planetf1 commented 3 years ago

If it's intended to implement this I suggest leaving it open, otherwise please feel free to close @yevgenmar