odpi / egeria

Egeria core
https://egeria-project.org
Apache License 2.0
795 stars 259 forks source link

Glossary canonical model sample does not work as a utility #4662

Open planetf1 opened 3 years ago

planetf1 commented 3 years ago

As found in https://github.com/odpi/egeria/issues/4661

Currently we provide the glossary canonical model sample in our assembly as samples//glossary-canonical-model-2.6-jar-with-dependencies.jar

The docs on how to use the parser reference an example file, and given we ship a utility one might think this would be the input parm on the tool ie:

java -jar ./glossary-canonical-model-2.6-jar-with-dependencies.jar ~/src/egeria/open-metadata-resources/open-metadata-archives/design-model-archives/glossary-canonical-model/src/test/resources/EgeriaSampleOntology.json

Model file Name: /Users/jonesn/src/egeria/open-metadata-resources/open-metadata-archives/design-model-archives/glossary-canonical-model/src/test/resources/EgeriaSampleOntology.json

Retrieving model contents from: /Users/jonesn/src/egeria/open-metadata-resources/open-metadata-archives/design-model-archives/glossary-canonical-model/src/test/resources/EgeriaSampleOntology.json
error is org.apache.jena.shared.NoReaderForLangException: Reader not found: JSON-LD

However this fails, since the main() used in this utility is actually in CanonicalGlossaryOwlArchiveWriter - it is not the input file for the parser. A sample of that can be found in the test code under org/odpi/openmetadata/archiveutilities/designmodels/owlcanonicalglossarymodel/TestOwlCanonicalGlossaryModelArchiveBuilder.java

As such what we have is incoherent.

We need to

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.