search

odpi / egeria

Egeria core
https://egeria-project.org
Apache License 2.0
795 stars 259 forks source link

Subject Area OMAS paging error #5388

Closed davidradl closed 3 years ago

davidradl commented 3 years ago

If you define 8 categories and then use a page size of 5 and get the first then the second page, you see 5 categories on the first page and 3 on the second page. One category is duplicated on each page and one is not shown. If you put the pageSize to 10 then you see all 8 categories.

I think this has gone unnoticed because the FVT only checks the number not that the results are correct.

davidradl commented 3 years ago

I am adding FVT tests to get them to fail. I will use this to decide whether I need to put ordering parameter on every call to be sure of the order. Initially I want to confirm that this is due to bad logic in the OMAS code and not in a lower layer.

I notice the FVTs still submitted .* and that the client library and the FVT wrapper had incorrect logic in around the setting of exactValue and mixed case. I am fixing these bugs in this issue as well.

davidradl commented 3 years ago

I am fixing https://github.com/odpi/egeria/issues/5390 separately from this issue

davidradl commented 3 years ago

Added more FVTs and have exposed some bugs, where .* was being used and is no longer supported , also the exactValue and ignoreCase flags were not being passed through appropriately in some cases.

davidradl commented 3 years ago

I have found the error in subject area OMAS, the startingFrom should is working off the unfiltered list ; it should work off the filtered list (i.e. search results after the searchCriteria have been applied).

davidradl commented 3 years ago

I am fixing this properly and more completely in https://github.com/odpi/egeria/issues/5399