coderabbitai[bot]
commented
4 months ago [!WARNING]
Rate limit exceeded
@kpob has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 12 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 09061b52c42c3990d016bfe1b72a8f968f54d535 and b1d80fbe76056d1a8f88e155c4385712bca0f833.
Walkthrough
This update introduces a new External module in the codebase, abstracting the complexities of managing contract references and addresses when calling external contracts. Additionally, the ExecutionError enum is enhanced to handle address-related errors, and several modules have been adjusted to leverage the new External component, simplifying interactions with external contracts.
Changes
| File Path | Summary |
|---|---|
core/src/external.rs |
Introduced the External module for external contract reference management. |
core/src/error.rs |
Added MissingAddress and AddressAlreadySet variants to ExecutionError. |
core/src/lib.rs |
Included and exported the new external module. |
examples/src/contracts/balance_checker.rs |
Updated BalanceChecker to include a token field of type External<TokenContractRef> and simplified the check_balance method. |
modules/src/cep78/utils.rs |
Modified MockCep78Operator to use External<NftContractContractRef> for nft_contract. |
odra-macros/src/ast/... |
Added SchemaErrorsItem and SchemaEventsItem structs and their implementations. |
odra-schema/src/custom_type.rs |
Added ContractRef and External to the import list and implemented SchemaEvents and SchemaErrors. |
odra/src/lib.rs |
Rearranged exports, added External entity, and adjusted position of GasReport. |
Sequence Diagram(s)
sequenceDiagram
participant BC as BalanceChecker
participant Ext as External<TokenContractRef>
participant TC as TokenContract
BC->>Ext: set(token_address: Address)
Ext->>TC: Store Address
BC->>Ext: check_balance(account: Address)
Ext->>TC: Retrieve token balance
TC->>Ext: Return balance
Ext->>BC: Return balancePossibly related issues
- Issue odradev/odra#469: The current PR simplifies external contract interactions by introducing the
Externalmodule, which directly aligns with the desired feature described in this issue.
Poem
In the realm of code so grand and vast,
Externalwas born to simplify tasks.
No more fuss with addresses and refs,
Just set it once, let it do the rest.
For contracts now communicate with ease,
Wrapped in elegance, developers at peace.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
github-actions[bot]
codecov[bot]
kubaplas
Summary by CodeRabbit
New Features
Externalmodule for handling and manipulating references to external contracts.BalanceCheckerto include atokenfield and streamlined thecheck_balancemethod.Bug Fixes
MissingAddressandAddressAlreadySetto improve address handling.Enhancements
MockCep78Operatorto use theExternaltrait, impacting method calls likemint,transfer, andapprove.SchemaErrorsItemandSchemaEventsItemfor better error and event management.Refactor
Externalentity and reordered others for clarity.