search

odudex / krux

Open-source, airgapped hardware signer for Bitcoin
https://selfcustody.github.io/krux/
Other
10 stars 2 forks source link

Feature Request: Brightness Setting #6

Closed hugoender closed 6 months ago

hugoender commented 1 year ago

Add brightness setting to settings page. The default brightness of 1 (minimum) is a bit too dim when using the device in well lit areas. I understand that making the display brighter may make the QR codes harder to read for some cameras so my recommendation for that is to lower the brightness when the device displays a QR code.

bitcoinheiro commented 1 year ago

Current brightness is great for phone reading, but I was testing a multisig setup the other day and loved that Krux saved the descriptor and also showed the QR code of the descriptor for exporting after it was loaded. I thought I would be able to use it to export to other signing devices, but the problem is that other simpler devices with low-res camera do need brighter QR codes to be able to import the descriptor. - so maybe some sort of brigthness setting on-the-fly, when the QR is showing, would be the best approach

odudex commented 1 year ago

Current brightness is great for phone reading, but I was testing a multisig setup the other day and loved that Krux saved the descriptor and also showed the QR code of the descriptor for exporting after it was loaded. I thought I would be able to use it to export to other signing devices, but the problem is that other simpler devices with low-res camera do need brighter QR codes to be able to import the descriptor. - so maybe some sort of brigthness setting on-the-fly, when the QR is showing, would be the best approach

Currently the animated QR codes toggle brightness mode when PAGE(down-next) button is pressed, as it is with the camera's "anti-glare" mode. I think it is a good idea to add this feature to static QR codes as well. For now what you can do is use the light theme, which is better suited for brighter environments. In light theme all QR codes will be brighter by default.

odudex commented 6 months ago

Backlight brightness control is now available on beta, for M5stickV and Cube