oduwsdl / CarbonDate

Estimating the age of web resources
MIT License
92 stars 11 forks source link

Bitly JSON exception handling #11

Closed grantat closed 7 years ago

grantat commented 7 years ago

Server logs were getting an exception when loading Bitly JSON which linked back to no exception handling. This pull adds exception handling to the response.

codecov-io commented 7 years ago

Codecov Report

Merging #11 into master will decrease coverage by 5.57%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   36.99%   31.41%   -5.58%     
==========================================
  Files          14       14              
  Lines         884      888       +4     
  Branches      121      121              
==========================================
- Hits          327      279      -48     
- Misses        526      598      +72     
+ Partials       31       11      -20
Impacted Files Coverage Δ
modules/cdGetBitly.py 11.82% <0%> (-29.75%) :arrow_down:
modules/cdGetBing.py 13.51% <0%> (-29.73%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 696be56...73b2361. Read the comment docs.