oduwsdl / MemGator

A Memento Aggregator CLI and Server in Go
https://memgator.cs.odu.edu/api.html
MIT License
56 stars 11 forks source link

Crossbuild script produces incomplete results with invalid architectures #135

Closed machawk1 closed 3 years ago

machawk1 commented 3 years ago

Using latest master d2ef4cfd07e258cef92cabe214f290fab7c239e8

I am running ./crossbuild.sh, which finishes with cmd/go: unsupported GOOS/GOARCH pair darwin/386. /tmp/mgbins/ only contains memgator-linux-386 & memgator-linux-amd64 , which indicates that this error prematurely exited and/or did not build every permutation.

go version go1.16.3 darwin/amd64

EDIT: PR incoming.

ibnesayeed commented 3 years ago

Golang has been working on removing support for darwin/386 for 1.15 and above. I see very little value in building and releasing 32-bit binaries of any platforms, because the audience of this tool is likely using a 64 bit machine. That said, if one wants to build it for a peculiar OS/Arch combo, they can do so manually.