oduwsdl / MemGator

A Memento Aggregator CLI and Server in Go
https://memgator.cs.odu.edu/api.html
MIT License
55 stars 11 forks source link

Change the default contact in the user-agent #90

Closed ibnesayeed closed 7 years ago

ibnesayeed commented 7 years ago

Currently, the default contact in the user-agent is listed as <@WebSciDL>. As a result, upstream servers often think the requests are coming from WSDL research group. We need to change the default to something else.

machawk1 commented 7 years ago

@ibnesayeed I presume a placeholder would work best here, correct? Maybe "@Administrator", "MEMGATOR_ADMIN", "CHANGE_ME", or something of the like?

ibnesayeed commented 7 years ago

I am thinking of changing it to <@WebSciDL (Default)>. It has been really helpful to keep @WebSciDL there as we were approached (and came to know about) when service providers faced some issues from MemGator instances that we don't control.

To make it more obvious, we can perhaps print a warning when MemGator is run in the server mode without custom contact or user agent (or spoof flag).

machawk1 commented 7 years ago

What might be better is to simply keep @WebSciDL sans (default), check the condition of that exact string and only then print a warning.

ibnesayeed commented 7 years ago

That would work too. So we basically only need to add that warning mechanism and that's all.