search

oduwsdl / tmvis

An archival thumbnail visualization server
MIT License
8 stars 7 forks source link

node version fix #49

Closed dhruv282 closed 5 years ago

dhruv282 commented 5 years ago

changes in node version

ibnesayeed commented 5 years ago

First of all, I would much prefer it is fixed to work with the latest version of node.

Secondly, if for some reason that can't happen then I would prefer the value of the NODE_TAG ARG is updated and not inline FROM directive, because ARG is there to allow building the image with different versions of the base image at build time by supplying --build-arg NODE_TAG=<some-node-version> argument.

Finally, I would not specify the patch version (the third point of the version number) to receive any security fixes in the near future and use something like 11.11 instead as the default value.

ibnesayeed commented 5 years ago

Please test these changes and let me know when it is ready to be merged. If the version 11.11 does not work then change it to 11.11.0 or any other version that seems to work for now.

dhruv282 commented 5 years ago

I just tested the changes and 11.11 works fine, thank you!

ibnesayeed commented 5 years ago

The quick fix is deployed, you should check if everything is working as expected on the live site.