Fix for older browsers - Githubissues

oduwsdl / tmvis

An archival thumbnail visualization server

MIT License

7 stars 7 forks source link

Fix for older browsers #56

Closed a-mabe closed 5 years ago

a-mabe commented 5 years ago

Site now works on older versions of Chrome and Firefox
Also added another fix for the histogram page occasionally not fully loading

ibnesayeed commented 5 years ago

How critical it is to support older browsers? Why are you getting rid of a more standard placeholder attribute in favor of a rather hacky approach of using values and clearing it then repopulating on focus and blur?

By the way if I can understand it correctly, you current logic will wipe the value off if someone intentionally filled the default value and the blur the focus out of the field.

a-mabe commented 5 years ago

It is to fix issue #52. If the user clicks the data field to type their own input, the field clears so that they don't have to erase it. If the user clicks out of the data field, the default value refills so they can still see the example input. This fix is working on current versions of Chrome and Firefox, as well as the versions mentioned in issue #52.

ibnesayeed commented 5 years ago

I have commented in #52 about it.

ibnesayeed commented 5 years ago

Let me know when you feel it is ready to be merged.

a-mabe commented 5 years ago

It is ready, it's working on old and new versions of browsers. Thank you!

ibnesayeed commented 5 years ago

I am merging this, but in a separate PR you might want to remove alert dialogue and add inline validation for a better user experience.