odyaka341 / alembic

Automatically exported from code.google.com/p/alembic
0 stars 0 forks source link

Alembic 1.1.0 uses big endian to hash on Windows/x86amd64. #292

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Compute the Murmur3 hash

What is the expected output? What do you see instead?
Shouldn't enter big endian code path.
The hash code is different from 1.0.5 for the same data on Windows.

What version of the product are you using? On what operating system?
Alembic 1.1.0 on Windows.

Please provide any additional information below.
In Alembic/Util/Murmur3.cpp, "#ifdef BOOST_BIG_ENDIAN" is replaced with "#if 
__BYTE_ORDER == __BIG_ENDIAN  || BYTE_ORDER == BIG_ENDIAN
".
On windows, all the macros are undefined. The result of comparison between 
undefined macros is true.

Original issue reported on code.google.com by shinc...@gmail.com on 20 Sep 2012 at 7:35

GoogleCodeExporter commented 9 years ago
Try this fix:

http://code.google.com/r/millerlucas-dev/source/detail?r=4d8ee1b571192a8cafc272c
faa8972970115ac45

Original comment by miller.lucas on 20 Sep 2012 at 4:40

GoogleCodeExporter commented 9 years ago
It works. Thanks for the fast fix!

Original comment by shinc...@gmail.com on 24 Sep 2012 at 5:50

GoogleCodeExporter commented 9 years ago

Original comment by miller.lucas on 12 Oct 2012 at 12:19