search

odyaka341 / thread-sanitizer

Automatically exported from code.google.com/p/thread-sanitizer
0 stars 0 forks source link

TSan runtime must be always built with -g #15

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
At Chrome we're building Clang using `make` (see 
http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/scripts/update.sh?re
vision=188142&view=markup), and this results in the runtime having no debug 
info (e.g. the report summaries contain '??:0' if the top frame contains a 
function interceptor).
This needs to be fixed, at least by adding -g to the appropriate makefiles (the 
best fix will involve dropping Makefile.old in favor of the Clang buildsystem 
configs)

Original issue reported on code.google.com by gli...@google.com on 18 Mar 2013 at 1:58

GoogleCodeExporter commented 9 years ago 
Why can't we use clang build system right now? Is the performance concern still 
valid?

Original comment by samso...@google.com on 18 Mar 2013 at 2:07

GoogleCodeExporter commented 9 years ago

Original comment by dvyu...@google.com on 6 May 2013 at 4:23

GoogleCodeExporter commented 9 years ago 
Yes, performance is still a concern for tsan.

Original comment by dvyu...@google.com on 6 May 2013 at 4:24

GoogleCodeExporter commented 9 years ago 
I remember that last time we checked that Clang used to generate more spills, 
but more efficient code. Was it so, or I got it wrong?
I think we must discuss the issue with someone familiar with the regalloc in 
LLVM. Relying on a fixed GCC version for building the runtime is definitely a 
wrong thing to do.

Original comment by ramosian.glider@gmail.com on 6 May 2013 at 6:28

GoogleCodeExporter commented 9 years ago 
Let's just add -g in the context of this bug.
Build system changes is a separate issue that must be discussed with chrome 
folks.

Original comment by dvyu...@google.com on 7 May 2013 at 7:01

GoogleCodeExporter commented 9 years ago 
Starting from r182260, make should build TSan runtime with debug info.

Original comment by samso...@google.com on 20 May 2013 at 1:42