odyaka341 / thread-sanitizer

Automatically exported from code.google.com/p/thread-sanitizer
0 stars 0 forks source link

race:foobar shouldn't match "afoobarz" #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
For some race reports the best suppression may contain a very short string, 
e.g. the name of the global ("mem0") or the top frame in the stack trace. It's 
quite likely that these strings will accidentally match other globals or other 
stack frames, which may lead to new races being unnoticed.

I see two possible ways to fix this:
 - introduce the "^" and "$" to match the beginning and the end of an entity (path, function name, global name), so that the users will have to write "race:^mem0$" if they want to restrict their suppressions. Obviously, nobody will
 - make "race:mem0" not imply "race:*mem0*", so that the users will have to explicitly denote that they want their pattern to match a substring.

Original issue reported on code.google.com by gli...@google.com on 11 Jul 2013 at 12:14

GoogleCodeExporter commented 9 years ago
I like "race:^mem0$"

Original comment by dvyu...@google.com on 15 Jul 2013 at 3:51

GoogleCodeExporter commented 9 years ago
Fixed by r186424.
The new suppressions format is "race:^mem0$".

Original comment by dvyu...@google.com on 16 Jul 2013 at 4:46