odygrd
commented
1 year ago hey I wrote you on this but probably missed it https://github.com/odygrd/quill/issues/273
Quill as a library doesn't have to be recompiled anymore to change the queue type in master. Therefore QUILL_USE_BOUNDED_QUEUE was removed from cmake. Previously this was propagating the flag from the library to your targets but it isn't there anymore
I think that is the issue, can you try add this flag to your benchmark in cmake and let me know if it works ? 1) When compiling quill lib you don't need to pass -DQUILL_USE_BOUNDED_QUEUE anymore, it has been removed from cmake options 2) For you specific target e.g. benchmark can you try to add this to your cmake please
target_compile_definitions(your_benchmark_target PUBLIC QUILL_USE_BOUNDED_QUEUE)
shuhaowu
I have a test program which works totally fine with quill v2.7.0 , I cloned on Feb 10 With the latest update from master I get a crash in quill:flush() This is what i see on stdout when I call quill::flush()
terminate called after throwing an instance of 'std::bad_variant_access' what(): Unexpected index Aborted (core dumped)
If I remove quill::flush() its all works fine
Running on Centos7 , gcc 7.3.1, compiled with -DQUILL_NO_EXCEPTIONS -DQUILL_USE_BOUNDED_QUEUE the quill lib and test program are compiled with same exact flags Test program is just 4 threads logging data .
This is the main int main() { quill::Config cfg; cfg.default_queue_capacity = 524288 ; quill::configure(cfg); quill::start(); std::cout<<" quill start 2"<<std::endl; quill::Handler file_handler = quill::rotating_file_handler(base_filename, "w", quill::FilenameAppend::None, 1001024, 5); //quill::Handler file_handler = quill::rotating_file_handler(base_filename, "w", 1001024, 5); file_handler->set_pattern("%(ascii_time) | %(level_name) | %(message)", "%Y-%m-%d %H:%M:%S.%Qus"); std::cout<<" create logger "<<std::endl; quill::Logger logger = quill::create_logger("rotating", file_handler); //quill::Logger logger = quill::get_logger(); logger->set_log_level(quill::LogLevel::TraceL3); LOG_TRACE_L3(logger, "This is a log trace l3 example {}", 1); LOG_TRACE_L2(logger, "This is a log trace l2 example {} {}", 2, 2.3); LOG_TRACE_L1(logger, "This is a log trace l1 {} example", "string"); //runBenchmark(logger); run_threads(logger,4);
}