Fix core dump when flush while the spsc queue doesn't have enough space.

odygrd / quill

Asynchronous Low Latency C++ Logging Library

MIT License

1.36k stars 142 forks source link

Fix core dump when flush while the spsc queue doesn't have enough space. #398

Closed Weissle closed 5 months ago

Weissle commented 6 months ago

Fix https://github.com/odygrd/quill/issues/397

odygrd commented 5 months ago

Thanks for the PR and the tests. I see this was missed when i updated the code in Logger.h to support multiple queue types. This behaviour seems fine to me, we just block on flush regardless of the queue type used