search

odyniec / imgareaselect

ImgAreaSelect is a jQuery plugin for selecting a rectangular area of an image. It allows web developers to easily implement image cropping functionality, as well as other user interface features, such as photo notes (like those on Flickr).
http://odyniec.net/projects/imgareaselect/
686 stars 197 forks source link

fix small global namespace pollution #47

Closed francescopellegrini closed 11 years ago

francescopellegrini commented 11 years ago

d variable ends up in the global namespace. This commit fix this behavior by declaring a local variable.

odyniec commented 11 years ago

Are you sure about the pollution? The variable is declared at the beginning of the plugin function (https://github.com/odyniec/imgareaselect/blob/master/jquery.imgareaselect.dev.js#L124), so this should not happen.

francescopellegrini commented 11 years ago

You're right, I completely missed that.. I apologize.