It didn't parse well number to me

odynvolk / number-of-search-results

A node module for retrieving number of search results for queries

3 stars 1 forks source link

It didn't parse well number to me #1

Closed davicente closed 6 years ago

odynvolk commented 6 years ago

Hi there!

Thanks for the PR! A couple of things... Could you use ES6 keywords, use the same indentation as I do (I just added an .editorconfig to master) and also add a test for the problem your code change fixes?

davicente commented 6 years ago

Hi again :)

I researched a little bit. The problem was the language, in spanish google search the amount of searchs are shown with a different format. I have a PR prepared to send with the fix and the unit test, but I'm not allowed to create a new branch and upload the commit.

It you can create a branch or give some permissions I can upload it.

Regards.

odynvolk commented 6 years ago

Hi there!

Aha! Good find! Yes there are probably more languages that don't work correctly at the moment.

Can't you just update this PR with the new commit?

Cheers!

davicente commented 6 years ago

I finally could send you a PR with the changes. Hope it helps