search

oe-alliance / AutoBouquetsMaker

Automatically build and update bouquets from the DVB stream.
GNU General Public License v3.0
23 stars 59 forks source link

Crash AutoBouquetsMaker on scan! #175

Closed m0807c closed 3 years ago

m0807c commented 3 years ago

Hi Oe-Alliance I get crash on scan any fix? Greeting enigma2_crash_1606773330.log

AbuBaniaz commented 3 years ago

Just for reference purposes

[ABM-main][checkTunerLock] ACQUIRING TSID/ONID
[ABM-Manager][read] Reading sat_130_tivusat...
[ABM-DvbScanner] Adapter 0
[ABM-DvbScanner] Demuxer 0
[ABM-DvbScanner] Frontend 0
[ABM-DvbScanner] DVBType dvbs
[ABM-DvbScanner] NIT pid: 0x10
[ABM-DvbScanner] NIT current table id: 0x40
[ABM-DvbScanner] NIT other table id: 0x41
[ABM-DvbScanner] Ignore visible service flag: 0
[ABM-DvbScanner] SDT pid: 0x11
[ABM-DvbScanner] SDT current table id: 0x42
[ABM-DvbScanner] SDT other table id: 0x46
[ABM-DvbScanner] Reading transponders...
Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Plugins/SystemPlugins/AutoBouquetsMaker/scanner/main.py", line 486, in doScan
  File "/usr/lib/enigma2/python/Plugins/SystemPlugins/AutoBouquetsMaker/scanner/manager.py", line 223, in read
  File "/usr/lib/enigma2/python/Plugins/SystemPlugins/AutoBouquetsMaker/scanner/dvbscanner.py", line 256, in updateTransponders
NameError: global name 'itervalues' is not defined
m0807c commented 3 years ago

Its software bug? or I must post log of ABM? I use OpenATV 6.4.

m0807c commented 3 years ago

20201203_095115 This is what I get :-(

morpheus883 commented 3 years ago

Uhm, maybe it's due to the fact that, on 13°E, Tivusat and Sky Italia are changing Transponder Systems and Modulations making the ABM scan difficult or impossible...

s3n0 commented 3 years ago

It is a BUG... please see my comment, on the last commit: https://github.com/oe-alliance/AutoBouquetsMaker/commit/e5babb95d8fc9be30334e0820ca55c9826c2b2f4#diff-8f207dd4349012263f0add852eeeb86b230d76dcfa4b95e7a7300a2cf791d298

morpheus883 commented 3 years ago

Probably, due to this issue, the plugin can't parse correctly data...

If it can help, here following my error log while I was running ABM on MEO/NOS (30°W):

[eDVBScan] the current channel's ID was not corrected - not adding channel. [eDVBScan] the current channel's ID was not corrected - not adding channel. [eDVBScan] the current channel's ID was not corrected - not adding channel. [eDVBScan] the current channel's ID was not corrected - not adding channel. [eDVBScan] the current channel's ID was not corrected - not adding channel. [eDVBScan] the current channel's ID was not corrected - not adding channel. Traceback (most recent call last): File "/usr/lib/enigma2/python/Plugins/SystemPlugins/AutoBouquetsMaker/scanner/main.py", line 516, in doScan File "/usr/lib/enigma2/python/Plugins/SystemPlugins/AutoBouquetsMaker/scanner/manager.py", line 223, in read

KeyError: 'hd_49165'

s3n0 commented 3 years ago

@morpheus883 :

You can try to undo the last commit. So you change the file in your set-top box to the previous file - as I described in the discussion on OpenATV: https://www.opena.tv/english-section/54279-crash-autobouquetsmaker-scan.html#post457949 You'll see if it helps or not.

Unfortunately, I don't own a set-top box on which the alpha build version of OpenATV 6.5 would work - with Python 3. So I can't test and debug the functionality in Python 3 and also in Python 2 under Enigma. I only own Formuler F4 Turbo and Vu+ Solo SE V2 set-top boxes.

patsavatv commented 3 years ago

Hello Use with ATV 6.4 on Vu + Duo 4K SE Also crash. Error on a file in the folder "scanner" I retrieved an October 31th backup of the full folder (scanner) and copied that folder to the decoder. No more crashes since. So there is a problem with one of the files! File "/usr/lib/enigma2/python/Plugins/SystemPlugins/AutoBouquetsMaker/scanner scanner.zip

s3n0 commented 3 years ago

Unfortunately, the last commit has already been approved. A "revert" must be done in the master branch or another fix must be added :). I have no way to test it. So I can't even try to fix it (without trying it). Theoretically, what I wrote in the comment below the last commit "dvbscanner.py handle itervalues for python 2/3" should help.

Before someone finally modifies it properly (so that it works correctly in both Python 2 and 3), you can download the previous version of the file (source code) + then restart Enigma / GUI. The source code is translated to a usable .pyo file format, and then the .py file is deleted:

wget -O /usr/lib/enigma2/python/Plugins/SystemPlugins/AutoBouquetsMaker/scanner/dvbscanner.py --no-check-certificate "https://github.com/oe-alliance/AutoBouquetsMaker/raw/b95210d951ded31b7783e2978ecb765f167bebb5/AutoBouquetsMaker/src/scanner/dvbscanner.py"
init 4; sleep 5; init 3; sleep 60
rm -f /usr/lib/enigma2/python/Plugins/SystemPlugins/AutoBouquetsMaker/scanner/dvbscanner.py

However, reverting to a previous version of a file is only a temporary solution.

m0807c commented 3 years ago

Its fixed big thanx to s3n0 and others ;-)

s3n0 commented 3 years ago

Well, it's not fixed yet :).

There is still an error in the source code yet.

I clicked revert the changes in this file, but I don't know if it will pass. The author of this change (of this "commit") should take care of the adjustment correctly. He should modify the source code to work. It could also be edited according to my example, which I gave in my comments on this particular "commit". However, I'm not sure because I don't know what the dictionary variable contains and I also don't have a device running some Enigma / Python3 firmware (alpha version of OpenATV for example).

Huevos commented 3 years ago

https://github.com/oe-alliance/AutoBouquetsMaker/commit/691635f5f1dd9475ee3214bf47906d24d55e3215

Please test.

morpheus883 commented 3 years ago

Now it works: problem seems solved... About 13°E: Sky Italy provider has wrong parameters....

Huevos commented 3 years ago

Please try: https://github.com/oe-alliance/AutoBouquetsMaker/commit/8a36c0a3c8fbddff5701251c0e200b70dec7119c

m0807c commented 3 years ago

Hi Huevous please add under Show DVB-T frequency finder support for DVB-T2 265 HEVC !

Huevos commented 3 years ago

265 has nothing to do with transponder parameters. All ABM/Frequency finder does is read the SI tables. It has no interest in video encoding. What problem are you having? Please be specific.

JoaoSobral commented 3 years ago

Hi,

I am also getting the same crash with Meo. My log below.

enigma2_crash_1607637027.log

JoaoSobral commented 3 years ago

@s3n0 @m0807c could you be so kind to provide me the dvbscanner.pyo with the fix? I love to try on my system.

Thanks

AbuBaniaz commented 3 years ago 
Pure2 Enigma2 crash log
crashdate=Thu Dec 10 22:50:27 2020
compiledate=Dec  3 2020
sourcedate=2020-11-30
branch=6.5

You need to use an image newer than 5th December which will have the fixed file. Otherwise uninstall then reinstall the plugin. The crash was fixed on 5th December.

https://github.com/oe-alliance/AutoBouquetsMaker/commit/691635f5f1dd9475ee3214bf47906d24d55e3215

I will close the issue now.

AbuBaniaz commented 3 years ago

@JoaoSobral PurE2 have updated their images.

JoaoSobral commented 3 years ago

@AbuBaniaz thanks. I will try later. 👍