search

oe-alliance / AutoBouquetsMaker

Automatically build and update bouquets from the DVB stream.
GNU General Public License v3.0
22 stars 59 forks source link

Request from OpenSPA, not issue #20

Closed OpenSPA closed 7 years ago

OpenSPA commented 7 years ago

Plugin doesn't work with OpenSPA image, but with small changes we get it working. Changes are included in setup.py file. We add these lines into class AutoBouquetsMaker_ProvidersSetup :

def keyLeft(self): ConfigListScreen.keyLeft(self) self.changedEntry()

def keyRight(self): ConfigListScreen.keyRight(self) self.changedEntry()

Is there any problem to include this lines into your plugin?

setup.zip

Ev0-BH commented 7 years ago

slightly off topic, but do you have any plans to commit your kodi 17 code to the oe-a git ?

Huevos commented 7 years ago

What is the purpose of that change. "bouquets" is always present, so that test is doing nothing.

See here: https://github.com/oe-alliance/AutoBouquetsMaker/blob/master/AutoBouquetsMaker/src/scanner/providers.py#L69

Huevos commented 7 years ago

Is there any problem to include this lines into your plugin?

I've tried the above change and it causes the provider's screen to run slow in other images. Need to understand why OpenSPA is not sending the onchange.

atvcaptain commented 7 years ago

use boxbranding if openspa; then bla bla else: old way

AbuBaniaz commented 7 years ago

Only the configuration is affected. Entering the values in settings file works. As ABM works on other images, would it not be better to look at the config issue? Issue could affect all other plugins too. So, instead of patching all plugins that do not work on Openspa, make Openspa work better with all plugins.

If that is not possible, then changes will have to be made to ABM provided they do not negatively affect it.

Huevos commented 7 years ago

We don't use boxbranding in ABM at the moment.

If we add that it will have to be in a try/except so the plugin continues to work in other images, i.e. OpenPLi, Blackhole, etc.

OpenSPA commented 7 years ago

I understand comments, but we don't find why is not working in our image. We continue searching why don't send the onchange. Is logical to adapt OpenSPA if plugin works in all other images, we know, but we requested this because it works with those easy lines. If it works bad in other images, no problem, we will wait until we find the issue.

@Ev0-BH I don't understand this off-topic, can you help me with ABM? Kodi is planned to be uploaded, but we request patience.

AbuBaniaz commented 7 years ago

Resolved with this https://github.com/oe-alliance/AutoBouquetsMaker/commit/bfd670cd86079a8a4b4e126acfbac18acfef0ee5