search

oe-alliance / AutoBouquetsMaker

Automatically build and update bouquets from the DVB stream.
GNU General Public License v3.0
23 stars 59 forks source link

New TP/TsId/OnId #216

Closed morpheus883 closed 2 years ago

AbuBaniaz commented 2 years ago

What are you wanting to change with this pull request? Have you tested it?

It is good practice that when you want to submit a change, you make a new branch. Make your pull request from the new branch. Once the pull request is merged, delete the new branch.

morpheus883 commented 2 years ago

All the pull requests are tested and directly verified.

AbuBaniaz commented 2 years ago

If there are no changes to 45e, there should be no commits about it in your pull request.

AbuBaniaz commented 2 years ago

To me, new Tuning details means you are amending existing ones. But the Viasat one was deleted in November https://github.com/oe-alliance/AutoBouquetsMaker/commit/1883ae74ba9c759af4dfab1d2805248913edddbe

Are you re-adding it with different tuning parameters and also that it works ?

morpheus883 commented 2 years ago

Yes, confirmed.

After some tests, now Viasat seems working on the new Frequency.

Morph

From: AbuBaniaz @.> Sent: Saturday, January 8, 2022 11:53 AM To: oe-alliance/AutoBouquetsMaker @.> Cc: morpheus883 @.>; Author @.> Subject: Re: [oe-alliance/AutoBouquetsMaker] New TP/TsId/OnId (PR #216)

To me, new Tuning details means you are amending existing ones. But the Viasat one was deleted in November 1883ae7https://github.com/oe-alliance/AutoBouquetsMaker/commit/1883ae74ba9c759af4dfab1d2805248913edddbe

Are you re-adding it with different tuning parameters and also that it works ?

— Reply to this email directly, view it on GitHubhttps://github.com/oe-alliance/AutoBouquetsMaker/pull/216#issuecomment-1007954203, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADBRETG2QFUUYZF57MJ7QLLUVAJUNANCNFSM5LBWSYDA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

AbuBaniaz commented 2 years ago

I have added it using the 4 digit orbital position in xml name. https://github.com/oe-alliance/AutoBouquetsMaker/commit/1f7246a18aa13571a34238b5fc6ca19da29c69a9