oe-alliance / enigma2-plugins

The original enigma2 plugins.
Other
45 stars 109 forks source link

Accents in channel name being dropped on autotimer on any channel #345

Open phunkyfish opened 5 years ago

phunkyfish commented 5 years ago

I have two autotimers. One bound to a channel and the other to any channel.

If it is bound to a channel the channel name is correctly stored as "RTÉ One" for any resulting timers. However, for the other which can run on any channel there is the channel name will be stored as "RTE One" which is incorrect.

phunkyfish commented 5 years ago

Note that the accents are standard ASCII characters and both autotimers use UTF-8 encoding:

https://gist.github.com/phunkyfish/e6bcb425364d454d0a5fef2f2b56eb5b

Huevos commented 5 years ago

There are no accents in standard ASCII charset.

phunkyfish commented 5 years ago

Sorry, I meant extended. Here is a timer created by both autotimers:

You'll see that one includes the accent (bound to one channel), and the second drops the accent (not bound to any channel):

https://gist.github.com/phunkyfish/a78d1c68188a3779b326bbd5d518565c

jbleyel commented 4 years ago

What image do you have and what exact autotimer source? I have checked this source -> https://github.com/oe-alliance/enigma2-plugins/tree/master/autotimer

The function to create the timer have no channel name as parameter. The servicename in autotimer.xml is only for information.

phunkyfish commented 4 years ago

I use OpenVix, latest image.

It uses the same source you referenced above.

Let me test this again with the latest version but I imagine this is an image issue and not OpenWebIf.

wedebe commented 3 years ago

I've got RTÉ channels on both satellite and terrestrial bouquets, using OpenATV and OpenWebif so can test later.

autotimer.xml stores channel refs with a comment (unused code) of channel name <serviceref>1:0:19:835:3EA:2174:EEEE0000:0:0:0:</serviceref> <!-- RTÉ One -->

I haven't checked the code, but I'd imagine the AutoTimers code passes that sref through to the image to deal with.

If you know how to copy files from the box, could you attach autotimer.xml and timers.xml with the relevant parts left in?

wedebe commented 3 years ago

Update to the above...

On OpenATV recent version via OpenWebIf I created:

and got the following:

Screen Shot 2021-02-23 at 14 49 03 Screen Shot 2021-02-23 at 14 50 38

autotimer.xml:

 <timer name="Six One" match="six one" enabled="yes" id="2" location="/media/hdd/movie/" offset="0" overrideAlternatives="1">
  <serviceref>1:0:19:835:3EA:2174:EEEE0000:0:0:0:</serviceref> <!-- RTÉ One -->
 </timer>

 <timer name="Nine O'Clock" match="nine o" enabled="yes" id="3" location="/media/hdd/movie/" offset="0" overrideAlternatives="1">
  <bouquet>1:7:1:0:0:0:0:0:0:0:FROM BOUQUET "userbouquet.favourites.tv" ORDER BY bouquet</bouquet> <!-- Favourites (TV) -->
 </timer>

 <timer name="One O'Clock" match="one o" enabled="yes" id="4" location="/media/hdd/movie/" offset="0" overrideAlternatives="1">
 </timer>

timers.xml:

<?xml version="1.0" ?>
<timers>
<timer begin="1614103260" end="1614106800" serviceref="1:0:19:835:3EA:2174:EEEE0000:0:0:0:" repeated="0" rename_repeat="1" name="RTÉ News: Six One" description="The latest news stories and in-depth reports. (HD, S)" afterevent="auto" eit="39487" location="/media/hdd/movie/" tags="" disabled="0" justplay="0" always_zap="0" descramble="1" record_ecm="0" isAutoTimer="1">
<log code="500" time="1614091007">[AutoTimer] Try to add new timer based on AutoTimer Six One.</log>
<log code="509" time="1614091007">[AutoTimer] Timer start on: Tue Feb 23 18:01:00 2021</log>
</timer>
<timer begin="1614114000" end="1614116100" serviceref="1:0:16:451:3E9:2174:EEEE0000:0:0:0:" repeated="0" rename_repeat="1" name="RTÉ News: Nine O&apos;Clock" description="The RTÉ News team delves into up-to-date news headlines of interest." afterevent="auto" eit="39799" location="/media/hdd/movie/" tags="" disabled="0" justplay="0" always_zap="0" descramble="1" record_ecm="0" isAutoTimer="1">
<log code="500" time="1614091006">[AutoTimer] Try to add new timer based on AutoTimer Nine O'Clock.</log>
<log code="509" time="1614091006">[AutoTimer] Timer start on: Tue Feb 23 21:00:00 2021</log>
</timer>
<timer begin="1614171600" end="1614173400" serviceref="1:0:16:451:3E9:2174:EEEE0000:0:0:0:" repeated="0" rename_repeat="1" name="RTÉ News: One O&apos;Clock" description="The RTÉ News team reports on the latest news and weather developments." afterevent="auto" eit="40070" location="/media/hdd/movie/" tags="" disabled="0" justplay="0" always_zap="0" descramble="1" record_ecm="0" isAutoTimer="1">
<log code="500" time="1614091664">[AutoTimer] Try to add new timer based on AutoTimer One O'Clock.</log>
<log code="509" time="1614091664">[AutoTimer] Timer start on: Wed Feb 24 13:00:00 2021</log>
</timer>
phunkyfish commented 3 years ago

And what is the is the output from the timerlist API call?

e.g. http:///web/timerlist

wedebe commented 3 years ago

/web/timerlist

<e2timerlist>
<e2timer>
<e2servicereference>1:0:19:835:3EA:2174:EEEE0000:0:0:0:</e2servicereference>
<e2servicename>RTÉ One</e2servicename>
<e2eit>39487</e2eit>
<e2name>RTÉ News: Six One</e2name>
<e2description>The latest news stories and in-depth reports. (HD, S)</e2description>
<e2descriptionextended>The latest news stories and in-depth reports. (HD, S)</e2descriptionextended>
<e2disabled>0</e2disabled>
<e2timebegin>1614103260</e2timebegin>
<e2timeend>1614106800</e2timeend>
<e2duration>3540</e2duration>
<e2startprepare>1614103240</e2startprepare>
<e2justplay>0</e2justplay>
<e2afterevent>3</e2afterevent>
<e2location>/media/hdd/movie/</e2location>
<e2tags/>
<e2logentries>[(1614091007, 500, '[AutoTimer] Try to add new timer based on AutoTimer Six One.'), (1614091007, 509, '[AutoTimer] Timer start on: Tue Feb 23 18:01:00 2021'), (1614103260, 11, 'Start recording')]</e2logentries>
<e2filename>/media/hdd/movie/20210223_1801_-_RT'E_ONE_-_RT'E_NEWS__SIX_ONE</e2filename>
<e2backoff>0</e2backoff>
<e2nextactivation>1614103260</e2nextactivation>
<e2firsttryprepare>0</e2firsttryprepare>
<e2state>2</e2state>
<e2repeated>0</e2repeated>
<e2dontsave>0</e2dontsave>
<e2cancled>False</e2cancled>
<e2toggledisabled>1</e2toggledisabled>
<e2toggledisabledimg>off</e2toggledisabledimg>
<e2alwayszap>0</e2alwayszap>
<e2pipzap>-1</e2pipzap>
</e2timer>
<e2timer>
<e2servicereference>1:0:16:451:3E9:2174:EEEE0000:0:0:0:</e2servicereference>
<e2servicename>RTÉ News Now</e2servicename>
<e2eit>39799</e2eit>
<e2name>RTÉ News: Nine O'Clock</e2name>
<e2description>The RTÉ News team delves into up-to-date news headlines of interest.</e2description>
<e2descriptionextended>The RTÉ News team delves into up-to-date news headlines of interest.</e2descriptionextended>
<e2disabled>0</e2disabled>
<e2timebegin>1614114000</e2timebegin>
<e2timeend>1614116100</e2timeend>
<e2duration>2100</e2duration>
<e2startprepare>1614113980</e2startprepare>
<e2justplay>0</e2justplay>
<e2afterevent>3</e2afterevent>
<e2location>/media/hdd/movie/</e2location>
<e2tags/>
<e2logentries>[(1614091006, 500, '[AutoTimer] Try to add new timer based on AutoTimer Nine O'Clock.'), (1614091006, 509, '[AutoTimer] Timer start on: Tue Feb 23 21:00:00 2021')]</e2logentries>
<e2filename/>
<e2backoff>0</e2backoff>
<e2nextactivation/>
<e2firsttryprepare>0</e2firsttryprepare>
<e2state>0</e2state>
<e2repeated>0</e2repeated>
<e2dontsave>0</e2dontsave>
<e2cancled>False</e2cancled>
<e2toggledisabled>1</e2toggledisabled>
<e2toggledisabledimg>off</e2toggledisabledimg>
<e2alwayszap>0</e2alwayszap>
<e2pipzap>-1</e2pipzap>
</e2timer>
<e2timer>
<e2servicereference>1:0:16:451:3E9:2174:EEEE0000:0:0:0:</e2servicereference>
<e2servicename>RTÉ News Now</e2servicename>
<e2eit>40070</e2eit>
<e2name>RTÉ News: One O'Clock</e2name>
<e2description>The RTÉ News team reports on the latest news and weather developments.</e2description>
<e2descriptionextended>The RTÉ News team reports on the latest news and weather developments.</e2descriptionextended>
<e2disabled>0</e2disabled>
<e2timebegin>1614171600</e2timebegin>
<e2timeend>1614173400</e2timeend>
<e2duration>1800</e2duration>
<e2startprepare>1614171580</e2startprepare>
<e2justplay>0</e2justplay>
<e2afterevent>3</e2afterevent>
<e2location>/media/hdd/movie/</e2location>
<e2tags/>
<e2logentries>[(1614091664, 500, '[AutoTimer] Try to add new timer based on AutoTimer One O'Clock.'), (1614091664, 509, '[AutoTimer] Timer start on: Wed Feb 24 13:00:00 2021')]</e2logentries>
<e2filename/>
<e2backoff>0</e2backoff>
<e2nextactivation/>
<e2firsttryprepare>0</e2firsttryprepare>
<e2state>0</e2state>
<e2repeated>0</e2repeated>
<e2dontsave>0</e2dontsave>
<e2cancled>False</e2cancled>
<e2toggledisabled>1</e2toggledisabled>
<e2toggledisabledimg>off</e2toggledisabledimg>
<e2alwayszap>0</e2alwayszap>
<e2pipzap>-1</e2pipzap>
</e2timer>
phunkyfish commented 3 years ago

That looks good compared the timer file gist I posted. Let me redo a test to see if the issue still occurs. If it happens for me still then it must be an OpenVix issue.