search

oe-alliance / oe-alliance-plugins

required oe-alliance plugins
Other
37 stars 138 forks source link

LCD4linux #781

Closed Marchella1983 closed 4 months ago

Marchella1983 commented 4 months ago

Good afternoon! Dear developers please add these improvements to the plugin oe-alliance/oe-alliance-plugins@ce2c6e7 to the plugin...

MrServo commented 4 months ago

Good morning! The suggestions have long since been incorporated into LCD4linux: https://github.com/oe-alliance/oe-alliance-plugins/commit/e149b036b41893ba75a775912c391def5c0098f5 Regards....Mr.Servo

Marchella1983 commented 4 months ago

Yes, but not all of them.

There is one small problem with viewing IPtv as media and there is a fix for it. https://github.com/oe-alliance/oe-alliance-plugins/pull/387/commits/2afb05d1c234b6e1d6fc9e722897faa9affb4aa8

please make changes to that too.

MrServo commented 4 months ago

Done! I hope I have now transferred all the suggested changes correctly... https://github.com/oe-alliance/oe-alliance-plugins/pull/782

Marchella1983 commented 4 months ago

Done! I hope I have now transferred all the suggested changes correctly... #782

Thank you so much! Everything's fine now.

Marchella1983 commented 4 months ago

one more correction If self.Lpath and self.Lpath.startswith("http") and self.Llength and self.Llength[0] == -1:

replace with if self.Lpath and self.Lpath.startswith((("http", "https")) and self.Llength and self.Llength[0] == -1:

Tnx @Dorik1972!

jbleyel commented 4 months ago

This change makes no difference to me.

Marchella1983 commented 4 months ago

This change makes no difference to me.

I'm sorry! It may not matter to you, but it does to us.

Is it a problem for you to correct this part of the code? https://github.com/oe-alliance/oe-alliance-plugins/blob/1a53f641752e2436c574e4b7b838070cb7e82d87/LCD4linux/src/plugin.py#L14486

jbleyel commented 4 months ago 
>>> Lpath = "https"
>>> Lpath.startswith("http")
True
>>>